User Tag List

Page 1 of 2 1 2 LastLast
Results 1 to 7 of 11

Thread: [Release] DarkCorE CMS

  1. #1
    OnTop500 <span style='color: #9400D3'><span class='glow_ADD8E6'>darksoke</span></span>'s Avatar
    Join Date
    Sep 2013
    Location
    Lost in a header file
    Posts
    507
    XP
    34,053
    Level
    56
    Thanks
    63
    Thanked 97 Times in 49 Posts

    [Release] DarkCorE CMS

    DarKcorE cms is a website designed for trinitycore I have created this website mostly for learning PHP , during the development process I found many tricks and useful things and i think it look really decent so far .

    First things first , this is not a rip off Azer-CMS or FusinCMS or WarcryCMS , everything is made from scratch by me and lately by contributors on github. Those who followed the development process know better all the stages this website been trough.

    I've been working on this CMS for a while , I think i have redesigned it over 10 times and it finally got into this new shape :)


    Contributors: Darksoke, DemonReborn, ProjectcoreDevs

    Ok DarKcorE CMS have the following working features so far:
    *-Working News Feed with user comment options * added the posibility to delete comment directly from comment list (GM only) *Old Pending for deletion
    *-Working Changelog module *Old Pending for deletion
    -Working improoved register module
    -Working Login/Logout module
    -Working user panel with different tools
    *-Working advanced vote panel (Advance?What's that? well you'll be able to see how much time until you can vote again and it will automatically increase the points on weekends) *Merged with user panel
    -Working Items,Characters,Guilds armory and a W.I.P Quests armory
    -Realm statistics total account/characters/quests/items & Characters online module
    -Rules and Regulations page
    -Guides Page
    -Builtin forum module (alpha)


    Note To Developers - You can join this project and do some pull requests if you feel like helping the emulation community also as I said this website started as a PHP learning atempt so you might expect the following:

    • First of all the code is very very bad when I started this project I only knew what echo does in PHP but this was 1 year ago so there are some repetitive functions or bad formated ones
    • The CMS is not complete it only have the coded website and is missing the administration panel
    • I kind of stoped the project in a style transition so the following pages were not updated yet
    • Rules Page
    • Registration Page
    • Guides Page
    • Forum module is in very very early stages and is not working









    GitHub Repository: https://github.com/darksoke/DarkCore-CMS

    !!Very Important Note!! Do not use it in this shape on a public server just please it have very big security issues. Also it might not work on latest trinitycore servers since this was a personal project i've created the server over my customized core

    Installation instructions
    • Move everything to to your HTDOCS now open up "For Install" folder
    • Run those 2 SQL files one is to update your account database and 1 is the base of the WEB DATABASE *Note the website is adapted for 12 Game Master ranks
    • Now move to core folder open "Config.php" and put there your database informations


    CHANGELOG
    • -Updated Armory style and search bar
    • -Created Store Page *ProjectCoreDevs - not uploaded yet
    • -Created Login Page *ProjectCoreDevs
    • -Updated headers , cleared more useless code
    • -Fixed the style on the following pages Guides/Rules/Registration
    • -Cleared a bunch of useless code
    • -Fixed many functions mostly on registration and armory part


    If you feel like helping us with the development process and see more updates faster you can help us by donating , all money will be spent on development process (paying all contributors and aquire-ing ressources) , also if you are HTML/CSS/JAVA/PHP/MySQL developer you can join us , so far we are only 3 contributors but we have already updated this website very much from it's initial form

    **If you donated from this forum , please leave us a comment or write it in your donation comment because for every donation received from here we are going to send a part of the money to NomSoft to help them reaching their goal.


    Last edited by darksoke; 01-27-2016 at 11:12 PM.
    Achievements:
    1 year registered Member Level L
    Awards:
    Raffle Winner

  2. The Following 4 Users Say Thank You to darksoke For This Useful Post:


  3. #2
    Founder <span style='color: #FF4500'>Tommy</span>'s Avatar
    Join Date
    Apr 2013
    Posts
    7,375
    XP
    3,447,768
    Level
    378
    Thanks
    887
    Thanked 1,848 Times in 1,117 Posts
    Thanks for sharing! Looks decent via graphics. Though, I have to be honest about most things.

    1. You should add ".idea" to gitignore as that shouldn't be on the repo.
    2. Why do you have two index files? Even though one is html and the other is php, you should only have one imo.
    3. Most of the columns you add to the account table are quite pointless. For example, "staff_id", "CustomRank". You can gather the needed data from account_access or rbac table to obtain who is staff and who is a player, rather than adding an entirely new column "staff_id" and "CustomRank". Not sure what "rank", "isactive" are used for. Any who, database could use some organizing.
    4. File organizing doesn't seem too bad but it could be better.
    5. The code is very ugly, especially the indentation, excessive use of div classes/other related code (which there are better ways in handling that in css in general) and the lack of a page system.
    6. You don't escape most of your variables (string) when inserting into your database. This is a security issue.


    Code like this:

    Code:
    	if (!isset($_POST['Username']) || 
    			!isset($_POST['Password']) || 
    				!isset($_POST['RepeatPassword']) || 
    					!isset($_POST['Email']) || 
    						!isset($_POST['RepeatEmail']) || 
    							!isset($_POST['Country']) || 
    								!isset($_POST['Age']) || 
    									!isset($_POST['foundus']) || 
    										!isset($_POST['robot1']) || 
    											!isset($_POST['robot2'])){
    Is just plain bad. You honestly should create variables instead of calling $_POST multiple times which can be redundant to do. On that note:

    Code:
    		if (check_user_exist($_POST['Username']) > 0)
    			$_error = $_error . 'A';
    		if (strlen($_POST['Username'])  < 3)
    			$_error = $_error . 'B';
    		if (strlen($_POST['Password'])  < 8)
    			$_error = $_error . 'C';
    		if (check_email_exist($_POST['Email']) > 0)
    			$_error = $_error . 'D';
    		if (strlen($_POST['Email'])  < 10) 
    			$_error = $_error . 'E';
    		if (strlen($_POST['Country'])  < 2) 
    			$_error = $_error . 'F';
    		if (strlen($_POST['Age'])  < 2) 
    			$_error = $_error . 'G';
    		if (strlen($_POST['foundus'])  < 5) 
    			$_error = $_error . 'H';
    		if (strlen($_POST['robot1'])  < 1) 
    			$_error = $_error . 'I';
    		if (strlen($_POST['robot2']) < 1)
    			$_error = $_error . 'J';
    		if ($_POST['Password'] != $_POST['RepeatPassword'])
    			$_error = $_error . 'K';
    		if ($_POST['Email'] != $_POST['RepeatEmail'])
    			$_error = $_error . 'L';
    		if ($_POST['robot1'] != $_POST['robot1-root'])
    			$_error = $_error . 'M';
    		if (strtoupper($_POST['robot2']) != $_POST['robot2-root'])
    			$_error = $_error . 'N';
    Why not create a global array that holds your register error message(s)? Or just simply check and if an error occurs return the error message string? For example:

    Code:
    $error = array(
            'a' => '<div id="notify">This username already exist</div>',
            'b' => '<div id="notify">Username must contain at least 3 characters</div>',
        );
    
    // Example:
    echo $error["a"];
    echo $error["b"];
    
    // Output:
    // This username already exist
    // Username must contain at least 3 characters
    
    // ... OR
    if (check_user_exist($_POST['Username']) > 0)
        return "This username already exists..";
    There's probably more but I'll stop here. Regardless, thanks for the share and keep up the work.

  4. #3
    Emulation Addict Recycle's Avatar
    Join Date
    May 2015
    Location
    Finland
    Posts
    67
    XP
    1,123
    Level
    8
    Thanks
    16
    Thanked 16 Times in 11 Posts
    It looks good, like, really good.

    I'll boot it up and see what kind of feedback I can give - Will edit this post with my thoughts.

  5. #4
    Original Poster
    OnTop500 <span style='color: #9400D3'><span class='glow_ADD8E6'>darksoke</span></span>'s Avatar
    Join Date
    Sep 2013
    Location
    Lost in a header file
    Posts
    507
    XP
    34,053
    Level
    56
    Thanks
    63
    Thanked 97 Times in 49 Posts
    Quote Originally Posted by Tommy View Post
    Thanks for sharing! Looks decent via graphics. Though, I have to be honest about most things.

    1. You should add ".idea" to gitignore as that shouldn't be on the repo.
    2. Why do you have two index files? Even though one is html and the other is php, you should only have one imo.
    3. Most of the columns you add to the account table are quite pointless. For example, "staff_id", "CustomRank". You can gather the needed data from account_access or rbac table to obtain who is staff and who is a player, rather than adding an entirely new column "staff_id" and "CustomRank". Not sure what "rank", "isactive" are used for. Any who, database could use some organizing.
    4. File organizing doesn't seem too bad but it could be better.
    5. The code is very ugly, especially the indentation, excessive use of div classes/other related code (which there are better ways in handling that in css in general) and the lack of a page system.
    6. You don't escape most of your variables (string) when inserting into your database. This is a security issue.


    Code like this:

    Code:
    	if (!isset($_POST['Username']) || 
    			!isset($_POST['Password']) || 
    				!isset($_POST['RepeatPassword']) || 
    					!isset($_POST['Email']) || 
    						!isset($_POST['RepeatEmail']) || 
    							!isset($_POST['Country']) || 
    								!isset($_POST['Age']) || 
    									!isset($_POST['foundus']) || 
    										!isset($_POST['robot1']) || 
    											!isset($_POST['robot2'])){
    Is just plain bad. You honestly should create variables instead of calling $_POST multiple times which can be redundant to do. On that note:

    Code:
    		if (check_user_exist($_POST['Username']) > 0)
    			$_error = $_error . 'A';
    		if (strlen($_POST['Username'])  < 3)
    			$_error = $_error . 'B';
    		if (strlen($_POST['Password'])  < 8)
    			$_error = $_error . 'C';
    		if (check_email_exist($_POST['Email']) > 0)
    			$_error = $_error . 'D';
    		if (strlen($_POST['Email'])  < 10) 
    			$_error = $_error . 'E';
    		if (strlen($_POST['Country'])  < 2) 
    			$_error = $_error . 'F';
    		if (strlen($_POST['Age'])  < 2) 
    			$_error = $_error . 'G';
    		if (strlen($_POST['foundus'])  < 5) 
    			$_error = $_error . 'H';
    		if (strlen($_POST['robot1'])  < 1) 
    			$_error = $_error . 'I';
    		if (strlen($_POST['robot2']) < 1)
    			$_error = $_error . 'J';
    		if ($_POST['Password'] != $_POST['RepeatPassword'])
    			$_error = $_error . 'K';
    		if ($_POST['Email'] != $_POST['RepeatEmail'])
    			$_error = $_error . 'L';
    		if ($_POST['robot1'] != $_POST['robot1-root'])
    			$_error = $_error . 'M';
    		if (strtoupper($_POST['robot2']) != $_POST['robot2-root'])
    			$_error = $_error . 'N';
    Why not create a global array that holds your register error message(s)? Or just simply check and if an error occurs return the error message string? For example:

    Code:
    $error = array(
            'a' => '<div id="notify">This username already exist</div>',
            'b' => '<div id="notify">Username must contain at least 3 characters</div>',
        );
    
    // Example:
    echo $error["a"];
    echo $error["b"];
    
    // Output:
    // This username already exist
    // Username must contain at least 3 characters
    
    // ... OR
    if (check_user_exist($_POST['Username']) > 0)
        return "This username already exists..";
    There's probably more but I'll stop here. Regardless, thanks for the share and keep up the work.
    thx man :D I will update soon :D bunc of code was added when i started learning php and i did not managed to update it yet :D thx for your feedback
    Achievements:
    1 year registered Member Level L
    Awards:
    Raffle Winner

  6. #5
    Member
    Join Date
    Jan 2016
    Posts
    1
    XP
    370
    Level
    4
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Great feedback

    Hey everyone,

    Thanks a lot for this fantastic feedback. Dark and I are both striving to make this CMS as user friendly as possible. Hopefully we'll be able to report back soon with some great updates :)

  7. #6
    Founder <span style='color: #FF4500'>Hyperion</span>'s Avatar
    Join Date
    Apr 2013
    Posts
    4,926
    XP
    755,588
    Level
    154
    Thanks
    1,390
    Thanked 1,182 Times in 630 Posts
    https://github.com/darksoke/DarkCore...l-functions.js

    lol #fuck, that's awesome ;D

    Looking nice, could use some cleanup/security but definitely looks better than others
    Achievements:
    Got a Sticky! Referrer Conversationalist 1 year registered Member Level XL Level C
    Awards:
    Member of Staff Support Smartass LOL Scripter Repacker Picasso Most Threads Facepalm! Pot Head On the fly Raffle Winner Drunk
    Upvote our public Teamspeak 3 Server!

  8. #7
    Original Poster
    OnTop500 <span style='color: #9400D3'><span class='glow_ADD8E6'>darksoke</span></span>'s Avatar
    Join Date
    Sep 2013
    Location
    Lost in a header file
    Posts
    507
    XP
    34,053
    Level
    56
    Thanks
    63
    Thanked 97 Times in 49 Posts
    Quote Originally Posted by Faded View Post
    https://github.com/darksoke/DarkCore...l-functions.js

    lol #fuck, that's awesome ;D

    Looking nice, could use some cleanup/security but definitely looks better than others
    Woah lol :)) i totaly forgot about that :)) it was my first atempt on making a show/hide button ragequit after :))after all i managed to make it with pure js+css
    Achievements:
    1 year registered Member Level L
    Awards:
    Raffle Winner

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •